Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1139113004: Revert of Remove test result whitespace stripping from blink_gc_plugin test script (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove test result whitespace stripping from blink_gc_plugin test script (patchset #1 id:1 of https://codereview.chromium.org/1132293003/) Reason for revert: This broke the blink_gc_plugin tests on Mac (I didn't try Linux yet). Reverting it solved the problem locally. Original issue's description: > Remove test result whitespace stripping from blink_gc_plugin test script > > To make things easier for future developers, the test script now parses > the options using argparse and provides a --reset-results flag to easily > update the baselines. > > BUG=none > > Committed: https://crrev.com/5171d85366fe1bd7c1de43e866adc3c3e50bc419 > Cr-Commit-Position: refs/heads/master@{#329904} TBR=thakis@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M tools/clang/blink_gc_plugin/tests/cycle_ptrs.txt View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/cycle_sub.txt View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/cycle_super.txt View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/cycle_super_neg.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/register_weak_members_template.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/test.py View 4 chunks +17 lines, -24 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_derived_from_templated_base.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_overloaded.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hans
Created Revert of Remove test result whitespace stripping from blink_gc_plugin test script
5 years, 7 months ago (2015-05-15 20:13:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139113004/1
5 years, 7 months ago (2015-05-15 20:14:16 UTC) #2
commit-bot: I haz the power
Failed to apply patch for tools/clang/blink_gc_plugin/tests/cycle_super_neg.txt: While running git apply --index -3 -p1; error: tools/clang/blink_gc_plugin/tests/cycle_super_neg.txt: ...
5 years, 7 months ago (2015-05-15 20:18:04 UTC) #4
hans
5 years, 7 months ago (2015-05-15 20:22:08 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698