Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 1139113002: Revert of Prevent stack overflow in the serializer/deserializer. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
mvstanton, Yang
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Prevent stack overflow in the serializer/deserializer. (patchset #6 id:100001 of https://codereview.chromium.org/1125073004/) Reason for revert: [Sheriff] Breaks msan: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2266 Original issue's description: > Prevent stack overflow in the serializer/deserializer. > > We keep an eye on the recursion depth. Once it exceeds a limit, we serialize > only the object header and size, but defer serializing the object body for > after we have unwound the stack. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/36b4a498d6614243454d5a182e4946b0dad24f0a > Cr-Commit-Position: refs/heads/master@{#28385} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/e1b5db6c8d118f2e015cff7724e9125163e9bca1 Cr-Commit-Position: refs/heads/master@{#28403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -215 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/snapshot/serialize.h View 11 chunks +10 lines, -46 lines 0 comments Download
M src/snapshot/serialize.cc View 21 chunks +33 lines, -120 lines 0 comments Download
M test/cctest/test-serialize.cc View 4 chunks +3 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Prevent stack overflow in the serializer/deserializer.
5 years, 7 months ago (2015-05-14 14:59:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139113002/1
5 years, 7 months ago (2015-05-14 14:59:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 14:59:35 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 14:59:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1b5db6c8d118f2e015cff7724e9125163e9bca1
Cr-Commit-Position: refs/heads/master@{#28403}

Powered by Google App Engine
This is Rietveld 408576698