Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1139103003: win: Fix module timestamp test (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Fix module timestamp test This test was added in https://codereview.chromium.org/1052813002. It was previously checking the timestamp from in-memory module traversal vs. the disk mtime. This is flaky (of course) because it depends on the linker writing the header and closing the file during the same time quantum. So the bots occasionally failed with: [ RUN ] ProcessInfo.Self e:\b\build\slave\chromium_win_dbg\build\crashpad\util\win\process_info_test.cc(86): error: Value of: GetTimestampForModule(GetModuleHandleW(nullptr)) Actual: 1431650338 Expected: modules[0].timestamp Which is: 1431650337 Instead, use imagehlp to pull the timestamp out of the header so that it matches the header value that will be the in-memory timestamp. R=cpu@chromium.org TBR=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8171e6f76591536e0670c76f42a31f3ccd37a90e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M util/util_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M util/win/process_info_test.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
5 years, 7 months ago (2015-05-15 00:59:20 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-05-15 01:42:52 UTC) #2
scottmg
5 years, 7 months ago (2015-05-15 01:45:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8171e6f76591536e0670c76f42a31f3ccd37a90e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698