Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1139063004: Add Clang ToT builder for iOS (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
Nico, smut
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org, smut, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Add Clang ToT builder for iOS To catch issues like https://codereview.chromium.org/1135023004/#msg21 earlier. BUG=452726 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295297

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M masters/master.chromium.fyi/master.cfg View 3 chunks +11 lines, -0 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/chromium_fyi.py View 2 chunks +22 lines, -1 line 3 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +5 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTiOS.json View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hans
Please take a look. Hopefully our buildbot Mac images have the build deps for targetting ...
5 years, 7 months ago (2015-05-18 21:38:42 UTC) #2
Nico
rs-lgtm +smut, sdefresne for their information (they – or at least smut – actually know ...
5 years, 7 months ago (2015-05-18 21:41:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139063004/1
5 years, 7 months ago (2015-05-18 21:46:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295297
5 years, 7 months ago (2015-05-18 21:52:25 UTC) #6
smut
https://codereview.chromium.org/1139063004/diff/1/scripts/slave/recipe_modules/chromium/chromium_fyi.py File scripts/slave/recipe_modules/chromium/chromium_fyi.py (right): https://codereview.chromium.org/1139063004/diff/1/scripts/slave/recipe_modules/chromium/chromium_fyi.py#newcode1216 scripts/slave/recipe_modules/chromium/chromium_fyi.py:1216: }, ios/unified_builder_tester is just going to ignore all this. ...
5 years, 7 months ago (2015-05-18 23:00:05 UTC) #8
hans
https://codereview.chromium.org/1139063004/diff/1/scripts/slave/recipe_modules/chromium/chromium_fyi.py File scripts/slave/recipe_modules/chromium/chromium_fyi.py (right): https://codereview.chromium.org/1139063004/diff/1/scripts/slave/recipe_modules/chromium/chromium_fyi.py#newcode1216 scripts/slave/recipe_modules/chromium/chromium_fyi.py:1216: }, On 2015/05/18 23:00:05, smut wrote: > ios/unified_builder_tester is ...
5 years, 7 months ago (2015-05-18 23:31:30 UTC) #9
hans
On 2015/05/18 23:31:30, hans wrote: > I'll prepare a patch. https://codereview.chromium.org/1145723003/
5 years, 7 months ago (2015-05-18 23:37:01 UTC) #10
smut
5 years, 7 months ago (2015-05-19 00:07:29 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/1139063004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium/chromium_fyi.py (right):

https://codereview.chromium.org/1139063004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/chromium_fyi.py:1216: },
On 2015/05/18 23:31:30, hans wrote:
> On 2015/05/18 23:00:05, smut wrote:
> > ios/unified_builder_tester is just going to ignore all this. Please
configure
> > this builder by looking here:
> >
>
https://chromium.googlesource.com/chromium/src/+/master/ios/build/bots/chromi...
> 
> But scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTiOS.json
> looks like it got configured correctly, but that one isn't used?
> 
> I'll prepare a patch.

full_chromium_fyi_ClangToTiOS.json is not the expectation for a bot using
ios/unified_builder_tester. The expectations for ios/unified_builder_tester are
located at scripts/slave/recipes/ios/unified_builder_tester.expected/.

Powered by Google App Engine
This is Rietveld 408576698