Index: cc/resources/one_copy_tile_task_worker_pool.cc |
diff --git a/cc/resources/one_copy_tile_task_worker_pool.cc b/cc/resources/one_copy_tile_task_worker_pool.cc |
index 23f372c15e2b13add87aacaa046b6a62528ac335..a1c0877ab8490408af61c04edca6c8ec607e1383 100644 |
--- a/cc/resources/one_copy_tile_task_worker_pool.cc |
+++ b/cc/resources/one_copy_tile_task_worker_pool.cc |
@@ -26,17 +26,24 @@ class RasterBufferImpl : public RasterBuffer { |
ResourceProvider* resource_provider, |
ResourcePool* resource_pool, |
ResourceFormat resource_format, |
- const Resource* resource) |
+ const TileTaskData& data) |
: worker_pool_(worker_pool), |
resource_provider_(resource_provider), |
resource_pool_(resource_pool), |
- resource_(resource), |
- raster_resource_( |
- resource_pool->AcquireResource(resource->size(), resource_format)), |
- lock_(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer( |
- resource_provider_, |
- raster_resource_->id())), |
- sequence_(0) {} |
+ tile_task_data_(data), |
+ reusing_raster_resource_(true), |
+ sequence_(0) { |
+ raster_resource_ = resource_pool->TryAcquireOldResource( |
+ data.resource->size(), resource_format, data.previous_tile_id); |
+ if (!raster_resource_) { |
+ raster_resource_ = resource_pool->AcquireResource(data.resource->size(), |
+ resource_format); |
+ reusing_raster_resource_ = false; |
+ } |
+ |
+ lock_.reset(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer( |
+ resource_provider_, raster_resource_->id())); |
+ } |
~RasterBufferImpl() override { |
// Release write lock in case a copy was never scheduled. |
@@ -47,10 +54,12 @@ class RasterBufferImpl : public RasterBuffer { |
if (sequence_) |
worker_pool_->AdvanceLastIssuedCopyTo(sequence_); |
- // Return raster resource to pool so it can be used by another RasterBuffer |
+ // Return resources to pool so they can be used by another RasterBuffer |
// instance. |
- if (raster_resource_) |
- resource_pool_->ReleaseResource(raster_resource_.Pass()); |
+ if (raster_resource_) { |
+ resource_pool_->ReleaseResource(raster_resource_.Pass(), |
+ tile_task_data_.new_tile_id); |
+ } |
} |
// Overridden from RasterBuffer: |
@@ -58,15 +67,16 @@ class RasterBufferImpl : public RasterBuffer { |
const gfx::Rect& rect, |
float scale) override { |
sequence_ = worker_pool_->PlaybackAndScheduleCopyOnWorkerThread( |
- lock_.Pass(), raster_resource_.Pass(), resource_, raster_source, rect, |
- scale); |
+ reusing_raster_resource_, lock_.Pass(), raster_resource_.Pass(), |
+ tile_task_data_, raster_source, rect, scale); |
} |
private: |
OneCopyTileTaskWorkerPool* worker_pool_; |
ResourceProvider* resource_provider_; |
ResourcePool* resource_pool_; |
- const Resource* resource_; |
+ TileTaskData tile_task_data_; |
+ bool reusing_raster_resource_; |
scoped_ptr<ScopedResource> raster_resource_; |
scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> lock_; |
CopySequenceNumber sequence_; |
@@ -90,10 +100,13 @@ const int kFailedAttemptsBeforeWaitIfNeeded = 256; |
} // namespace |
OneCopyTileTaskWorkerPool::CopyOperation::CopyOperation( |
- scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> write_lock, |
- scoped_ptr<ScopedResource> src, |
- const Resource* dst) |
- : write_lock(write_lock.Pass()), src(src.Pass()), dst(dst) { |
+ scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> |
+ raster_resource_write_lock, |
+ scoped_ptr<ScopedResource> raster_resource, |
+ const TileTaskData& data) |
+ : raster_resource_write_lock(raster_resource_write_lock.Pass()), |
+ raster_resource(raster_resource.Pass()), |
+ tile_task_data(data) { |
} |
OneCopyTileTaskWorkerPool::CopyOperation::~CopyOperation() { |
@@ -262,12 +275,11 @@ ResourceFormat OneCopyTileTaskWorkerPool::GetResourceFormat() { |
} |
scoped_ptr<RasterBuffer> OneCopyTileTaskWorkerPool::AcquireBufferForRaster( |
- const Resource* resource) { |
- DCHECK_EQ(resource->format(), resource_provider_->best_texture_format()); |
+ const TileTaskData& data) { |
+ DCHECK_EQ(data.resource->format(), resource_provider_->best_texture_format()); |
return make_scoped_ptr<RasterBuffer>( |
new RasterBufferImpl(this, resource_provider_, resource_pool_, |
- resource_provider_->best_texture_format(), |
- resource)); |
+ resource_provider_->best_texture_format(), data)); |
} |
void OneCopyTileTaskWorkerPool::ReleaseBufferForRaster( |
@@ -277,9 +289,11 @@ void OneCopyTileTaskWorkerPool::ReleaseBufferForRaster( |
CopySequenceNumber |
OneCopyTileTaskWorkerPool::PlaybackAndScheduleCopyOnWorkerThread( |
- scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> write_lock, |
- scoped_ptr<ScopedResource> src, |
- const Resource* dst, |
+ bool reusing_raster_resource, |
+ scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> |
+ raster_resource_write_lock, |
+ scoped_ptr<ScopedResource> raster_resource, |
+ const TileTaskData& tile_task_data, |
const RasterSource* raster_source, |
const gfx::Rect& rect, |
float scale) { |
@@ -319,21 +333,30 @@ OneCopyTileTaskWorkerPool::PlaybackAndScheduleCopyOnWorkerThread( |
{ |
base::AutoUnlock unlock(lock_); |
- gfx::GpuMemoryBuffer* gpu_memory_buffer = write_lock->GetGpuMemoryBuffer(); |
+ gfx::GpuMemoryBuffer* gpu_memory_buffer = |
+ raster_resource_write_lock->GetGpuMemoryBuffer(); |
if (gpu_memory_buffer) { |
- void* data = NULL; |
- bool rv = gpu_memory_buffer->Map(&data); |
+ void* raster_data = nullptr; |
+ bool rv = gpu_memory_buffer->Map(&raster_data); |
DCHECK(rv); |
int stride; |
gpu_memory_buffer->GetStride(&stride); |
- TileTaskWorkerPool::PlaybackToMemory(data, src->format(), src->size(), |
- stride, raster_source, rect, scale); |
+ |
+ gfx::Rect playback_rect = rect; |
+ if (reusing_raster_resource) |
+ playback_rect.Intersect(tile_task_data.raster_dirty_rect); |
+ DCHECK(!playback_rect.IsEmpty()) |
+ << "Why are we rastering a tile that's not dirty?"; |
+ TileTaskWorkerPool::PlaybackToMemory( |
+ raster_data, raster_resource->format(), raster_resource->size(), |
+ stride, raster_source, rect, playback_rect, scale); |
gpu_memory_buffer->Unmap(); |
} |
} |
- pending_copy_operations_.push_back( |
- make_scoped_ptr(new CopyOperation(write_lock.Pass(), src.Pass(), dst))); |
+ pending_copy_operations_.push_back(make_scoped_ptr( |
+ new CopyOperation(raster_resource_write_lock.Pass(), |
+ raster_resource.Pass(), tile_task_data))); |
// Acquire a sequence number for this copy operation. |
CopySequenceNumber sequence = next_copy_operation_sequence_++; |
@@ -412,15 +435,17 @@ void OneCopyTileTaskWorkerPool::IssueCopyOperations(int64 count) { |
scoped_ptr<CopyOperation> copy_operation = copy_operations.take_front(); |
// Remove the write lock. |
- copy_operation->write_lock.reset(); |
+ copy_operation->raster_resource_write_lock.reset(); |
// Copy contents of source resource to destination resource. |
- resource_provider_->CopyResource(copy_operation->src->id(), |
- copy_operation->dst->id()); |
+ resource_provider_->CopyResource( |
+ copy_operation->raster_resource->id(), |
+ copy_operation->tile_task_data.resource->id()); |
// Return source resource to pool where it can be reused once copy |
// operation has completed and resource is no longer busy. |
- resource_pool_->ReleaseResource(copy_operation->src.Pass()); |
+ resource_pool_->ReleaseResource(copy_operation->raster_resource.Pass(), |
+ copy_operation->tile_task_data.new_tile_id); |
} |
} |