Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1139043004: [Android] Round instead if truncate for selection coordinates (Closed)

Created:
5 years, 7 months ago by jdduke (slow)
Modified:
5 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Round instead if truncate for selection coordinates Composited selection coordinates are in floating pointer DIPs. However, current APIs for manipulating the selection are all in integral coordinates. This leads to cases where an adjusted selection can chaotically hop across selection region boundaries. Until all platforms adopt unified selection and we transition the APIs to use floating point coordinates, use rounded coordinates when manipulating the selection from the browser. BUG=489852 Committed: https://crrev.com/f7bf4534d8d520cbb2d8f4e896beec4368067ed9 Cr-Commit-Position: refs/heads/master@{#330640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/browser/android/content_view_core_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
PTAL, simplest fix we can cherry-pick...
5 years, 7 months ago (2015-05-19 21:09:36 UTC) #2
boliu
lgtm
5 years, 7 months ago (2015-05-19 21:14:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139043004/1
5 years, 7 months ago (2015-05-19 22:29:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 22:37:01 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:38:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7bf4534d8d520cbb2d8f4e896beec4368067ed9
Cr-Commit-Position: refs/heads/master@{#330640}

Powered by Google App Engine
This is Rietveld 408576698