Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1139033005: Make the c and ac scripts work with sh and without bin in PATH (Closed)

Created:
5 years, 7 months ago by Kimmo Kinnunen
Modified:
5 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make the c and ac scripts work with sh and without bin in PATH Make the bin/c and bin/ac scripts work with sh. The scripts are run with /bin/sh shebang, which fails atleast on ubuntu 12.04 /bin/sh. The sh in Ubuntu 12.04 is dash. The fixes are according to the suggestions in http://mywiki.wooledge.org/Bashism Also run "compare" script with explicit ./bin/ path to support people who do not have skia/bin in PATH. Committed: https://skia.googlesource.com/skia/+/c77f6af7c3ca08c94b882ccb2fbd61e6bae7ea42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M bin/ac View 2 chunks +2 lines, -2 lines 0 comments Download
M bin/c View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kimmo Kinnunen
5 years, 7 months ago (2015-05-15 11:56:40 UTC) #2
mtklein
lgtm
5 years, 7 months ago (2015-05-15 12:29:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139033005/1
5 years, 7 months ago (2015-05-15 12:30:17 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 12:36:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c77f6af7c3ca08c94b882ccb2fbd61e6bae7ea42

Powered by Google App Engine
This is Rietveld 408576698