Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1139033002: Remove a HistoryNode's children when it navigates to a new document. (Closed)

Created:
5 years, 7 months ago by Nate Chapin
Modified:
5 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a HistoryNode's children when it navigates to a new document. When a reload occurs (or other inert commits), we leave the history tree alone. However, if iframes are dynamically created, we end up with both the old iframes and the new iframes in the history tree, and we never prune them. Instead, if a different-document inert commit occurs, remove the committing node's children, since the corresponding frames are no longer in the frame tree. BUG=485385 Committed: https://crrev.com/9f3e29c910ce2c2a9c3a60b2675db59d95b8ad3a Cr-Commit-Position: refs/heads/master@{#329763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/renderer/history_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nate Chapin
5 years, 7 months ago (2015-05-13 23:27:44 UTC) #2
Charlie Reis
LGTM
5 years, 7 months ago (2015-05-13 23:35:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139033002/1
5 years, 7 months ago (2015-05-13 23:39:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 00:35:26 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9f3e29c910ce2c2a9c3a60b2675db59d95b8ad3a Cr-Commit-Position: refs/heads/master@{#329763}
5 years, 7 months ago (2015-05-14 00:36:15 UTC) #7
Charlie Reis
5 years, 7 months ago (2015-05-18 21:46:40 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1148473002/ by creis@chromium.org.

The reason for reverting is: Caused a large spike in crashes across several
bugs:
https://crbug.com/426658
https://crbug.com/488382
https://crbug.com/488421
https://crbug.com/488434
https://crbug.com/488470.

Powered by Google App Engine
This is Rietveld 408576698