net/ssl/ssl_config_service_unittest.cc - Issue 1139013002: Completely remove SSLv3 support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/ssl_config_service_unittest.cc

Issue 1139013002: Completely remove SSLv3 support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ssl/ssl_config_service_unittest.cc

diff --git a/net/ssl/ssl_config_service_unittest.cc b/net/ssl/ssl_config_service_unittest.cc

index 7306c68d71319a596f7c6028651413ef1523e8b2..7428dd00eb96f0b220e8f88647b73043f6c6ae95 100644

--- a/net/ssl/ssl_config_service_unittest.cc

+++ b/net/ssl/ssl_config_service_unittest.cc

@@ -49,8 +49,8 @@ TEST(SSLConfigServiceTest, NoChangesWontNotifyObservers) {

SSLConfig initial_config;

initial_config.rev_checking_enabled = true;

initial_config.false_start_enabled = false;

- initial_config.version_min = SSL_PROTOCOL_VERSION_SSL3;

- initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_1;

+ initial_config.version_min = SSL_PROTOCOL_VERSION_TLS1;

+ initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_2;

scoped_refptr<MockSSLConfigService> mock_service(

new MockSSLConfigService(initial_config));

@@ -67,8 +67,8 @@ TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {

SSLConfig initial_config;

initial_config.rev_checking_enabled = true;

initial_config.false_start_enabled = false;

- initial_config.version_min = SSL_PROTOCOL_VERSION_SSL3;

- initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_1;

+ initial_config.version_min = SSL_PROTOCOL_VERSION_TLS1;

+ initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_2;

scoped_refptr<MockSSLConfigService> mock_service(

new MockSSLConfigService(initial_config));

@@ -85,11 +85,11 @@ TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {

mock_service->SetSSLConfig(initial_config);

// Test that changing the SSL version range triggers updates.

- initial_config.version_min = SSL_PROTOCOL_VERSION_TLS1;

+ initial_config.version_min = SSL_PROTOCOL_VERSION_TLS1_1;

EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);

mock_service->SetSSLConfig(initial_config);

- initial_config.version_max = SSL_PROTOCOL_VERSION_SSL3;

+ initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_1;

EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);

mock_service->SetSSLConfig(initial_config);