Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1139013002: Completely remove SSLv3 support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 88e3d276338de528faf996bc56001372d0456cda..6645f5a875a013d5ee333ab26ed470e879ae1277 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -11089,8 +11089,8 @@ TEST_P(HttpNetworkTransactionTest,
// [ssl_]data3 contains the data for the third SSL handshake. When a
// connection to a server fails during an SSL handshake,
- // HttpNetworkTransaction will attempt to fallback to TLSv1 if the previous
- // connection was attempted with TLSv1.1. This is transparent to the caller
+ // HttpNetworkTransaction will attempt to fallback to TLSv1.1 if the previous
+ // connection was attempted with TLSv1.2. This is transparent to the caller
// of the HttpNetworkTransaction. Because this test failure is due to
// requiring a client certificate, this fallback handshake should also
// fail.
@@ -11102,8 +11102,8 @@ TEST_P(HttpNetworkTransactionTest,
// [ssl_]data4 contains the data for the fourth SSL handshake. When a
// connection to a server fails during an SSL handshake,
- // HttpNetworkTransaction will attempt to fallback to SSLv3 if the previous
- // connection was attempted with TLSv1. This is transparent to the caller
+ // HttpNetworkTransaction will attempt to fallback to TLSv1 if the previous
+ // connection was attempted with TLSv1.1. This is transparent to the caller
// of the HttpNetworkTransaction. Because this test failure is due to
// requiring a client certificate, this fallback handshake should also
// fail.
@@ -11113,13 +11113,6 @@ TEST_P(HttpNetworkTransactionTest,
StaticSocketDataProvider data4(NULL, 0, NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&data4);
- // Need one more if TLSv1.2 is enabled.
- SSLSocketDataProvider ssl_data5(ASYNC, ERR_SSL_PROTOCOL_ERROR);
- ssl_data5.cert_request_info = cert_request.get();
- session_deps_.socket_factory->AddSSLSocketDataProvider(&ssl_data5);
- StaticSocketDataProvider data5(NULL, 0, NULL, 0);
- session_deps_.socket_factory->AddSocketDataProvider(&data5);
-
scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));

Powered by Google App Engine
This is Rietveld 408576698