Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 1138993009: Revert of [Android] Refactor the native test wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/test_runner.py ('k') | build/android/pylib/utils/apk_helper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index f9957b089cba82cff6d24aff34d3d2011fe5f63c..0633f1466dfd79a6c1906b7db7de4f313f354e6d 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -201,9 +201,8 @@
if not os.path.exists(self._test_jar):
error_func('Unable to find test JAR: %s' % self._test_jar)
- apk = apk_helper.ApkHelper(self.test_apk)
- self._test_package = apk.GetPackageName()
- self._test_runner = apk.GetInstrumentationName()
+ self._test_package = apk_helper.GetPackageName(self.test_apk)
+ self._test_runner = apk_helper.GetInstrumentationName(self.test_apk)
self._package_info = None
for package_info in constants.PACKAGE_INFO.itervalues():
@@ -275,9 +274,10 @@
constants.GetOutDirectory(), constants.SDK_BUILD_APKS_DIR,
'OnDeviceInstrumentationDriver.apk')
if os.path.exists(self._driver_apk):
- driver_apk = apk_helper.ApkHelper(self._driver_apk)
- self._driver_package = driver_apk.GetPackageName()
- self._driver_name = driver_apk.GetInstrumentationName()
+ self._driver_package = apk_helper.GetPackageName(
+ self._driver_apk)
+ self._driver_name = apk_helper.GetInstrumentationName(
+ self._driver_apk)
else:
self._driver_apk = None
« no previous file with comments | « build/android/pylib/gtest/test_runner.py ('k') | build/android/pylib/utils/apk_helper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698