Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1138993009: Revert of [Android] Refactor the native test wrappers. (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jbudorick+watch_chromium.org, jochen+watch_chromium.org, klundberg+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Refactor the native test wrappers. (patchset #7 id:120001 of https://codereview.chromium.org/1126543009/) Reason for revert: broke http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android e.g. http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/1922 Original issue's description: > [Android] Refactor the native test wrappers. > > BUG=476410 > > Committed: https://crrev.com/581d25e509e4a2b1e8927c6d8accc0c90ea86090 > Cr-Commit-Position: refs/heads/master@{#330531} TBR=jochen@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,perezju@chromium.org,tedchoc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476410 Committed: https://crrev.com/6cdb69279cb4f83fd8d1f31f58eb0edf44d2bec3 Cr-Commit-Position: refs/heads/master@{#330591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -425 lines) Patch
M build/android/pylib/constants/__init__.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +10 lines, -9 lines 0 comments Download
M build/android/pylib/gtest/local_device_gtest_run.py View 6 chunks +12 lines, -22 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 chunk +7 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 2 chunks +6 lines, -6 lines 0 comments Download
M build/android/pylib/utils/apk_helper.py View 2 chunks +16 lines, -57 lines 0 comments Download
D build/apk_browsertest.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/test/android/unit_tests_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 2 chunks +15 lines, -1 line 0 comments Download
M components/components_tests.gyp View 3 chunks +18 lines, -3 lines 0 comments Download
M components/test/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +0 lines, -4 lines 0 comments Download
A components/test/android/browsertests_apk/components_browser_tests_android.h View 1 chunk +16 lines, -0 lines 0 comments Download
A components/test/android/browsertests_apk/components_browser_tests_android.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M components/test/android/browsertests_apk/components_browser_tests_jni_onload.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java View 2 chunks +26 lines, -11 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 4 chunks +6 lines, -3 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +0 lines, -4 lines 0 comments Download
A content/shell/android/browsertests_apk/content_browser_tests_android.h View 1 chunk +16 lines, -0 lines 0 comments Download
A content/shell/android/browsertests_apk/content_browser_tests_android.cc View 1 chunk +101 lines, -0 lines 0 comments Download
M content/shell/android/browsertests_apk/content_browser_tests_jni_onload.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java View 2 chunks +26 lines, -11 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test.gyp View 2 chunks +21 lines, -37 lines 0 comments Download
M testing/android/native_test/BUILD.gn View 2 chunks +18 lines, -19 lines 0 comments Download
M testing/android/native_test/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
D testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java View 1 chunk +0 lines, -46 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 5 chunks +48 lines, -45 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java View 4 chunks +8 lines, -14 lines 0 comments Download
D testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java View 1 chunk +0 lines, -48 lines 0 comments Download
M testing/android/native_test/native_test_jni_onload.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/android/native_test/native_test_launcher.h View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M testing/android/native_test/native_test_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/android/native_test/native_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android] Refactor the native test wrappers.
5 years, 7 months ago (2015-05-19 20:03:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138993009/1
5 years, 7 months ago (2015-05-19 20:05:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 20:08:20 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 20:09:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cdb69279cb4f83fd8d1f31f58eb0edf44d2bec3
Cr-Commit-Position: refs/heads/master@{#330591}

Powered by Google App Engine
This is Rietveld 408576698