Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: build/java_apk.gypi

Issue 1138953003: Extract apkbuilder build action into a .gypi (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split-manifest
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | tools/telemetry/telemetry/TELEMETRY_DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index cece2be5e4a11f5c30b825c5e076986c958968e1..fb2ba30ae698c82931d571132aeba28545add2be 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -688,7 +688,8 @@
],
'conditions': [
['native_lib_target != ""', {
- 'inputs': [ '<(native_libraries_java_stamp)' ],
+ 'inputs': [ '<!(echo "<(_target_name): <(native_lib_target)" >> /tmp/foo.txt)',
cjhopman 2015/05/14 00:30:42 What's this needed for?
agrieve 2015/05/14 13:47:29 Whoops! That was your test :P. Removed.
+ '<(native_libraries_java_stamp)' ],
}],
],
'outputs': [
@@ -920,52 +921,16 @@
],
},
{
- 'action_name': 'ant_package_<(_target_name)',
- 'message': 'Packaging <(_target_name)',
'variables': {
- # Write the inputs list to a file, so that its mtime is updated when
- # the list of inputs changes.
- 'inputs_list_file': '>|(apk_package.<(_target_name).gypcmd >@(package_input_paths))'
+ 'apk_path': '<(unsigned_apk_path)',
+ 'native_libs_dir': '<(apk_package_native_libs_dir)',
+ 'conditions': [
+ ['native_lib_target != ""', {
+ 'extra_inputs': ['<(native_lib_placeholder_stamp)'],
+ }],
+ ],
},
- 'inputs': [
- '<(DEPTH)/build/android/ant/apk-package.xml',
- '<(DEPTH)/build/android/gyp/util/build_utils.py',
- '<(DEPTH)/build/android/gyp/ant.py',
- '<(dex_path)',
- '<(codegen_stamp)',
- '<(obfuscate_stamp)',
- '<(resource_packaged_apk_path)',
- '>@(package_input_paths)',
- '>(inputs_list_file)',
- ],
- 'outputs': [
- '<(unsigned_apk_path)',
- ],
- 'conditions': [
- ['native_lib_target != ""', {
- 'inputs': ['<(native_lib_placeholder_stamp)'],
- }],
- ],
- 'action': [
- 'python', '<(DEPTH)/build/android/gyp/ant.py',
- '--',
- '-quiet',
- '-DDEX_FILE_PATH=<(intermediate_dir)/classes.dex',
- '-DANDROID_SDK_ROOT=<(android_sdk_root)',
- '-DANDROID_SDK_TOOLS=<(android_sdk_tools)',
- '-DRESOURCE_PACKAGED_APK_NAME=<(resource_packaged_apk_name)',
- '-DAPK_NAME=<(apk_name)',
- '-DCONFIGURATION_NAME=<(CONFIGURATION_NAME)',
- '-DNATIVE_LIBS_DIR=<(apk_package_native_libs_dir)',
- '-DOUT_DIR=<(intermediate_dir)',
- '-DUNSIGNED_APK_PATH=<(unsigned_apk_path)',
- '-DEMMA_INSTRUMENT=<(emma_instrument)',
- '-DEMMA_DEVICE_JAR=<(emma_device_jar)',
-
- '-Dbasedir=.',
- '-buildfile',
- '<(DEPTH)/build/android/ant/apk-package.xml',
- ]
+ 'includes': ['android/apkbuilder_action.gypi'],
},
],
}
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | tools/telemetry/telemetry/TELEMETRY_DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698