QUIC - Temporary fix for b/20760730 until channel_id_service is

QUIC - Temporary fix for b/20760730 until channel_id_service is
supported in cronet to fix a crash bug in cronet.

BUG=487355
R=mef@chromium.org, rch@chromium.org

Committed: https://crrev.com/357efa37f670eafb0283fa6ae48ff4ac02839efe
Cr-Commit-Position: refs/heads/master@{#329494}

[mef, 2015-05-12 20:04:03]

https://codereview.chromium.org/1138943002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/1138943002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:584: crypto_config_.SetChannelIDSource(
Is it safe? What would happen here:
https://code.google.com/p/chromium/codesearch#chromium/src/net/quic/quic_cryp...

[Ryan Hamilton, 2015-05-12 20:23:19]

lgtm

https://codereview.chromium.org/1138943002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/1138943002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:584: crypto_config_.SetChannelIDSource(
On 2015/05/12 20:04:03, mef wrote:
> Is it safe? What would happen here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/net/quic/quic_cryp...

I *think* it's ok because of the call to RequiresChannelID().

[mef, 2015-05-12 20:26:19]

lgtm

https://codereview.chromium.org/1138943002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/1138943002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:584: crypto_config_.SetChannelIDSource(
On 2015/05/12 20:23:19, Ryan Hamilton wrote:
> On 2015/05/12 20:04:03, mef wrote:
> > Is it safe? What would happen here:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/net/quic/quic_cryp...
> 
> I *think* it's ok because of the call to RequiresChannelID().

Ah, right, RequiresChannelID() has a check for
crypto_config_->channel_id_source().

[ramant (doing other things), 2015-05-12 20:29:00]

On 2015/05/12 20:26:19, mef wrote:
> lgtm
> 
>
https://codereview.chromium.org/1138943002/diff/1/net/quic/quic_stream_factor...
> File net/quic/quic_stream_factory.cc (right):
> 
>
https://codereview.chromium.org/1138943002/diff/1/net/quic/quic_stream_factor...
> net/quic/quic_stream_factory.cc:584: crypto_config_.SetChannelIDSource(
> On 2015/05/12 20:23:19, Ryan Hamilton wrote:
> > On 2015/05/12 20:04:03, mef wrote:
> > > Is it safe? What would happen here:
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/net/quic/quic_cryp...
> > 
> > I *think* it's ok because of the call to RequiresChannelID().
> 
> Ah, right, RequiresChannelID() has a check for
> crypto_config_->channel_id_source().

+1. Thanks Ryan and Misha.

[ramant (doing other things), 2015-05-12 20:29:22]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2015-05-12 20:30:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138943002/1

[commit-bot: I haz the power, 2015-05-12 21:27:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-12 21:28:49]

Patchset 1 (id:??) landed as
https://crrev.com/357efa37f670eafb0283fa6ae48ff4ac02839efe
Cr-Commit-Position: refs/heads/master@{#329494}