Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1138933003: [Telemetry] Enable benchmark runner to list most closely matched input benchmark names. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Enable benchmark runner to list most closely matched input benchmark names.. After this patch, "./tools/perf/run_benchmark smoothness_key_silk_cases" will list out "smoothness.key_silk_cases" as the top matched benchmark. BUG=482090 Committed: https://crrev.com/74829d51c072a86fc5d1962e061c2cb7343a7d04 Cr-Commit-Position: refs/heads/master@{#329503}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Only print matched benchmarks if there is any #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -2 lines) Patch
M tools/telemetry/telemetry/benchmark_runner.py View 1 4 chunks +34 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_runner_unittest.py View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nednguyen
5 years, 7 months ago (2015-05-12 17:34:41 UTC) #2
sullivan
lgtm https://codereview.chromium.org/1138933003/diff/1/tools/telemetry/telemetry/benchmark_runner.py File tools/telemetry/telemetry/benchmark_runner.py (right): https://codereview.chromium.org/1138933003/diff/1/tools/telemetry/telemetry/benchmark_runner.py#newcode77 tools/telemetry/telemetry/benchmark_runner.py:77: in |all_benchmarks. nit: missing | in |all_benchmarks|. https://codereview.chromium.org/1138933003/diff/1/tools/telemetry/telemetry/benchmark_runner.py#newcode241 ...
5 years, 7 months ago (2015-05-12 18:08:33 UTC) #3
nednguyen
https://codereview.chromium.org/1138933003/diff/1/tools/telemetry/telemetry/benchmark_runner.py File tools/telemetry/telemetry/benchmark_runner.py (right): https://codereview.chromium.org/1138933003/diff/1/tools/telemetry/telemetry/benchmark_runner.py#newcode77 tools/telemetry/telemetry/benchmark_runner.py:77: in |all_benchmarks. On 2015/05/12 18:08:33, sullivan wrote: > nit: ...
5 years, 7 months ago (2015-05-12 20:18:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138933003/20001
5 years, 7 months ago (2015-05-12 20:19:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 21:53:47 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 21:54:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74829d51c072a86fc5d1962e061c2cb7343a7d04
Cr-Commit-Position: refs/heads/master@{#329503}

Powered by Google App Engine
This is Rietveld 408576698