Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2510)

Unified Diff: content/renderer/gin_browsertest.cc

Issue 113893005: [gin] Introduce Wrappable::GetObjectTemplate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/stats_collection_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/gin_browsertest.cc
diff --git a/content/renderer/gin_browsertest.cc b/content/renderer/gin_browsertest.cc
index 3f69fbb8ab8a558384a7acd26b53dffe4385ac34..a4e2c10bd3082d91f35cd4dae4b073c4510e7f78 100644
--- a/content/renderer/gin_browsertest.cc
+++ b/content/renderer/gin_browsertest.cc
@@ -37,14 +37,6 @@ class TestGinObject : public gin::Wrappable<TestGinObject> {
gin::WrapperInfo TestGinObject::kWrapperInfo = { gin::kEmbedderNativeGin };
-void RegisterTemplates(v8::Isolate* isolate) {
- gin::PerIsolateData* data = gin::PerIsolateData::From(isolate);
-
- v8::Handle<v8::ObjectTemplate> templ = v8::ObjectTemplate::New(isolate);
- templ->SetInternalFieldCount(gin::kNumberOfInternalFields);
- data->SetObjectTemplate(&TestGinObject::kWrapperInfo, templ);
-}
-
class GinBrowserTest : public RenderViewTest {
public:
GinBrowserTest() {}
@@ -75,8 +67,6 @@ TEST_F(GinBrowserTest, GinAndGarbageCollection) {
v8::Context::Scope context_scope(
view_->GetWebView()->mainFrame()->mainWorldScriptContext());
- RegisterTemplates(isolate);
-
// We create the object inside a scope so it's not kept alive by a handle
// on the stack.
TestGinObject::Create(isolate, &alive);
« no previous file with comments | « no previous file | content/renderer/stats_collection_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698