win: Retrieve "simple map" annotations from modules

snapshot/win/module_snapshot_win.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "snapshot/win/module_snapshot_win.h"
 
 #include "base/strings/utf_string_conversions.h"
+#include "snapshot/win/pe_image_annotations_reader.h"
 #include "snapshot/win/pe_image_reader.h"
 #include "util/misc/tri_state.h"
 #include "util/misc/uuid.h"
 #include "util/win/module_version.h"
 
 namespace crashpad {
 namespace internal {
 
 ModuleSnapshotWin::ModuleSnapshotWin()
     : ModuleSnapshot(),
@@ skipping 118 matching lines @@
 }
 
 void ModuleSnapshotWin::UUID(crashpad::UUID* uuid) const {
   INITIALIZATION_STATE_DCHECK_VALID(initialized_);
   // TODO(scottmg): Not sure if there's anything equivalent on Windows.
   *uuid = crashpad::UUID();
 }
 
 std::vector<std::string> ModuleSnapshotWin::AnnotationsVector() const {
   INITIALIZATION_STATE_DCHECK_VALID(initialized_);
-  CHECK(false) << "TODO(scottmg)";
+  // These correspond to system-logged things on Mac. We don't currently track
+  // any of these on Windows, but could in the future.

[Robert Sesek, 2015/05/14 18:55:27]

Is this worth filing a bug for?

[scottmg, 2015/05/14 19:10:02]

Good idea, https://code.google.com/p/crashpad/issues/detail?id=38

   return std::vector<std::string>();
 }
 
 std::map<std::string, std::string> ModuleSnapshotWin::AnnotationsSimpleMap()
     const {
   INITIALIZATION_STATE_DCHECK_VALID(initialized_);
-  CHECK(false) << "TODO(scottmg)";
-  return std::map<std::string, std::string>();
+  PEImageAnnotationsReader annotations_reader(
+      process_reader_, pe_image_reader_.get(), name_);
+  return annotations_reader.SimpleMap();
 }
 
 }  // namespace internal
 }  // namespace crashpad