Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138883003: Disable token handle fetching on some devices (Closed)

Created:
5 years, 7 months ago by Denis Kuznetsov (DE-MUC)
Modified:
5 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable token handle fetching on some devices BUG=484690 R=nkostylev@chromium.org Committed: https://crrev.com/48d2ad5189aa36c822624a225304cfe6374d3a1f Cr-Commit-Position: refs/heads/master@{#329828}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/browser/chromeos/login/existing_user_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Denis Kuznetsov (DE-MUC)
5 years, 7 months ago (2015-05-12 18:18:30 UTC) #1
Nikita (slow)
lgtm https://chromiumcodereview.appspot.com/1138883003/diff/1/chrome/browser/chromeos/login/existing_user_controller.h File chrome/browser/chromeos/login/existing_user_controller.h (right): https://chromiumcodereview.appspot.com/1138883003/diff/1/chrome/browser/chromeos/login/existing_user_controller.h#newcode250 chrome/browser/chromeos/login/existing_user_controller.h:250: // Returns |true| if token handles should be ...
5 years, 7 months ago (2015-05-13 08:33:37 UTC) #2
Nikita (slow)
https://chromiumcodereview.appspot.com/1138883003/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc File chrome/browser/chromeos/login/existing_user_controller.cc (right): https://chromiumcodereview.appspot.com/1138883003/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc#newcode1263 chrome/browser/chromeos/login/existing_user_controller.cc:1263: bool ExistingUserController::TokenHandlesEnabled() { I suggest having static function in ...
5 years, 7 months ago (2015-05-13 08:34:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138883003/20001
5 years, 7 months ago (2015-05-14 10:10:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 11:00:04 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 11:00:54 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/48d2ad5189aa36c822624a225304cfe6374d3a1f
Cr-Commit-Position: refs/heads/master@{#329828}

Powered by Google App Engine
This is Rietveld 408576698