Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1138873003: Restore virtual keyboard after switch back to FULL_WIDTH mode (Closed)

Created:
5 years, 7 months ago by bshe
Modified:
5 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore virtual keyboard after switch back to FULL_WIDTH mode After user decided to switch back to FULL_WIDTH mode, Chrome should: 1. immediately position the virtual keyboard to the bottom of screen and use the screen width as its window width 2. notify web contents about the new virtual keyboard bounds so web contents can be scrolled correctly to avoid occlussion. BUG=487343 Committed: https://crrev.com/d3bb267e8e6043eb37074f27673a13d83c89c052 Cr-Commit-Position: refs/heads/master@{#329690}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M ui/keyboard/keyboard_controller.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bshe
Hey Sadrul. Do you mind to take a look at this CL? Thanks! Biao
5 years, 7 months ago (2015-05-12 18:33:46 UTC) #2
sadrul
Can this have a test?
5 years, 7 months ago (2015-05-12 19:41:43 UTC) #3
bshe
On 2015/05/12 19:41:43, sadrul wrote: > Can this have a test? definitely! I was planning ...
5 years, 7 months ago (2015-05-12 22:04:00 UTC) #4
sadrul
Thanks! lgtm
5 years, 7 months ago (2015-05-13 16:34:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138873003/20001
5 years, 7 months ago (2015-05-13 18:18:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 19:06:52 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:07:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3bb267e8e6043eb37074f27673a13d83c89c052
Cr-Commit-Position: refs/heads/master@{#329690}

Powered by Google App Engine
This is Rietveld 408576698