Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1138843002: localStorage: Aggressively flush to disk for Android WebView. (Closed)

Created:
5 years, 7 months ago by cmumford
Modified:
5 years, 7 months ago
Reviewers:
michaeln, jsbell
CC:
android-webview-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

localStorage: Aggressively flush to disk for Android WebView. Android WebView does not save data during shutdown like Chrome does. Adding an --enable-aggressive-domstorage-flushing flag to return the DOM Storage implementation to the prior implementation which had a 1 sec. timer to flush the commit queue. NOTRY=true NOPRESUBMIT=true TBR=jsbell BUG=479767 Review URL: https://codereview.chromium.org/1129233003 Cr-Commit-Position: refs/heads/master@{#329070} (cherry picked from commit a1f8d834ce9fc89e5e409e08bb00173c37854329)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/dom_storage/dom_storage_area.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/dom_storage/dom_storage_area.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
cmumford
Looking for l-g-t-m from michaeln or jsbell - needs to land today for M43. One ...
5 years, 7 months ago (2015-05-11 22:46:38 UTC) #2
boliu
merges can generally be TBR-ed
5 years, 7 months ago (2015-05-11 23:26:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138843002/1
5 years, 7 months ago (2015-05-12 00:20:22 UTC) #5
boliu
On 2015/05/12 00:20:22, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 7 months ago (2015-05-12 00:23:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 00:23:50 UTC) #7
boliu
5 years, 7 months ago (2015-05-12 00:24:25 UTC) #8
Message was sent while issue was closed.
On 2015/05/12 00:23:50, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1)

Oh, huh... didn't know that worked. Never mind me then :)

Powered by Google App Engine
This is Rietveld 408576698