Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 113883003: - Add a priority field to QuicCryptoServerConfig configs and used it as (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, agl, avd, wtc
Visibility:
Public.

Description

- Add a priority field to QuicCryptoServerConfig configs and used it as a secondary sort key when there are multiple configs with the same primary time. - Fixes to QuicCryptoServerConfig::SetConfigs to allow replacing all configs including the primary config in one go. - Change the name of QuicCryptoServerConfig::DefaultConfig to GenerateConfig. - Generalize the method of the StrikeRegisterClient interface used to verify orbits of new configs so that it allows for orbit changes or strike registers that know about multiple orbits. Merge internal change: 58556020 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -135 lines) Patch
M net/quic/crypto/crypto_server_config_protobuf.h View 2 chunks +17 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_config_protobuf.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/local_strike_register_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/crypto/local_strike_register_client.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M net/quic/crypto/local_strike_register_client_test.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 2 chunks +8 lines, -3 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 13 chunks +92 lines, -79 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 12 chunks +175 lines, -42 lines 0 comments Download
M net/quic/crypto/strike_register_client.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
Hi Adam, Ryan and Wan-Teh, Ported Antonio's CL to chromium (we used scoped_refptr for config). ...
6 years, 11 months ago (2014-01-04 03:48:27 UTC) #1
Ryan Hamilton
lgtm
6 years, 11 months ago (2014-01-06 04:25:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/113883003/1
6 years, 11 months ago (2014-01-06 17:39:19 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 20:10:16 UTC) #4
Message was sent while issue was closed.
Change committed as 243151

Powered by Google App Engine
This is Rietveld 408576698