Tag closures with their types

lib/src/js/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_ast;
 
 abstract class NodeVisitor<T> {
   T visitProgram(Program node);
 
   T visitBlock(Block node);
@@ skipping 1116 matching lines @@
 
   void visitChildren(NodeVisitor visitor) {}
 
   ArrayHole _clone() => new ArrayHole();
 
   int get precedenceLevel => PRIMARY;
 }
 
 class ObjectInitializer extends Expression {
   final List<Property> properties;
+  final bool vertical;

[Jennifer Messerly, 2015/05/19 18:19:01]

This could be computed:

bool _vertical;
bool get vertical {
  if (_vertical == null) {
    _vertical = properties.any((p) => p.value is FunctionExpression;
  }
  return _vertical;
}

And then that simplifies Printer.

Not sure I like that better or worse, just throwing it out as an idea to see
what you think :)

Regardless, maybe add a doc comment:

/**
 * If set to true, forces a vertical layout when using the [Printer].
 * Otherwise, layout will be vertical if and only if any [properties]
 * are [FunctionExpression]s.
 */

[Leaf, 2015/05/19 22:31:13]

Done.

 
   /**
    * Constructs a new object-initializer containing the given [properties].
    */
-  ObjectInitializer(this.properties);
+  ObjectInitializer(this.properties, {this.vertical: false});
 
   accept(NodeVisitor visitor) => visitor.visitObjectInitializer(this);
 
   void visitChildren(NodeVisitor visitor) {
     for (Property init in properties) init.accept(visitor);
   }
 
   ObjectInitializer _clone() => new ObjectInitializer(properties);
 
   int get precedenceLevel => PRIMARY;
@@ skipping 288 matching lines @@
   final Expression expression;
 
   CommentExpression(this.comment, this.expression);
 
   int get precedenceLevel => PRIMARY;
   accept(NodeVisitor visitor) => visitor.visitCommentExpression(this);
   CommentExpression _clone() => new CommentExpression(comment, expression);
 
   void visitChildren(NodeVisitor visitor) => expression.accept(visitor);
 }