Issue 1138783003: Fix uninitialized memory error Valgrind bots are barking about.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1138783003: Fix uninitialized memory error Valgrind bots are barking about. (Closed)

Created:
5 years, 7 months ago by Dan Beam

Modified:
5 years, 7 months ago

Reviewers:
jonross, benwells, raymes

CC:
chromium-reviews, erikwright+watch_chromium.org, robert.bradford, Lei Zhang

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix uninitialized memory error Valgrind bots are barking about. This was introduced by raymes@' lossy JSON pref CL: https://codereview.chromium.org/1127963002 TBR=benwells@chromium.org,raymes@chromium.org BUG=none

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	base/prefs/json_pref_store.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138783003/1

5 years, 7 months ago (2015-05-11 17:41:13 UTC) #5

Dan Beam

5 years, 7 months ago (2015-05-11 18:02:28 UTC) #7

moving the fix to here instead:
https://codereview.chromium.org/1136133002/

(the original CL was reverted)