Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1138773006: Fix webstore extension reading in views. (Closed)

Created:
5 years, 7 months ago by David Tseng
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dtseng+watch_chromium.org, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix webstore extension reading in views. Reading of views is now handled using ChromeVox Next with the automation API. The current Next background page fails on non-CROS because there's no commands block. We get an error like getAll called on undefined. (chrome.commands is undefined). TEST=manually build ChromeVox; verify views reads properly. Committed: https://crrev.com/6cd3b230c3b280a037efb2db8048e4cda4f69fbc Cr-Commit-Position: refs/heads/master@{#330249}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
David Tseng
5 years, 7 months ago (2015-05-15 20:04:35 UTC) #2
dmazzoni
lgtm
5 years, 7 months ago (2015-05-15 23:50:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138773006/20001
5 years, 7 months ago (2015-05-15 23:51:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-16 00:36:45 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:29:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6cd3b230c3b280a037efb2db8048e4cda4f69fbc
Cr-Commit-Position: refs/heads/master@{#330249}

Powered by Google App Engine
This is Rietveld 408576698