Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1138763004: Fix record_wpr to allow page tests to customize browser options. (Closed)

Created:
5 years, 7 months ago by USE eero AT chromium.org
Modified:
5 years, 7 months ago
Reviewers:
nednguyen, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix record_wpr to allow page tests to customize browser options. This changes RecorderPageTest class to pass CustomizeBrowserOptions to a page test object if there is one. BUG=486776 Committed: https://crrev.com/52afaaa94312daa02712ed510d70b0b892c68f47 Cr-Commit-Position: refs/heads/master@{#329375}

Patch Set 1 #

Patch Set 2 : Unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
USE eero AT chromium.org
PTAL. This fixes records with page tests which require customized browser options so that they ...
5 years, 7 months ago (2015-05-11 16:39:22 UTC) #2
nednguyen
Can you add test coverage for this in record_wpr_unittest.py?
5 years, 7 months ago (2015-05-11 16:40:35 UTC) #3
USE eero AT chromium.org
On 2015/05/11 16:40:35, nednguyen (slow review) wrote: > Can you add test coverage for this ...
5 years, 7 months ago (2015-05-11 17:15:43 UTC) #4
nednguyen
lgtm
5 years, 7 months ago (2015-05-11 19:15:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138763004/20001
5 years, 7 months ago (2015-05-12 07:28:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 08:26:45 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 08:27:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/52afaaa94312daa02712ed510d70b0b892c68f47
Cr-Commit-Position: refs/heads/master@{#329375}

Powered by Google App Engine
This is Rietveld 408576698