Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1138753003: Remove unused blitting functions from ui/gfx/blit.cc (Closed)

Created:
5 years, 7 months ago by spang
Modified:
5 years, 7 months ago
Reviewers:
sadrul, davidben
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused blitting functions from ui/gfx/blit.cc There are no remaining call sites for either BlitContextToCanvas or BlitCanvasToContext. Also remove some leftover #includes. TEST=Linux built compiles & links. Committed: https://crrev.com/3f631cbe673528365f8c0d26188a4a00c942f946 Cr-Commit-Position: refs/heads/master@{#330543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M content/plugin/webplugin_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/sad_plugin.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/blit.h View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/gfx/blit.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
spang
5 years, 7 months ago (2015-05-15 22:03:31 UTC) #2
sadrul
lgtm assuming all the bots are green
5 years, 7 months ago (2015-05-15 22:05:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138753003/1
5 years, 7 months ago (2015-05-15 23:21:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64215)
5 years, 7 months ago (2015-05-15 23:32:43 UTC) #7
spang
+davidben for content/OWNERS
5 years, 7 months ago (2015-05-19 15:59:30 UTC) #9
davidben
lgtm
5 years, 7 months ago (2015-05-19 16:05:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138753003/1
5 years, 7 months ago (2015-05-19 16:23:43 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 17:20:51 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:21:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f631cbe673528365f8c0d26188a4a00c942f946
Cr-Commit-Position: refs/heads/master@{#330543}

Powered by Google App Engine
This is Rietveld 408576698