Issue 113873008: remove unused SkFixed and SkFract functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113873008: remove unused SkFixed and SkFract functions (Closed)

Created:
7 years ago by reed1

Modified:
7 years ago

Reviewers:
djsollen, caryclark

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

remove unused SkFixed and SkFract functions BUG= R=caryclark@google.com Committed: https://code.google.com/p/skia/source/detail?r=12767

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -858 lines)			Patch
M	experimental/Intersection/SkAntiEdge.cpp	View	1 chunk	+8 lines, -0 lines	1 comment	Download
M	gyp/core.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/core/Sk64.h	View	3 chunks	+1 line, -54 lines	0 comments	Download
M	include/core/SkFixed.h	View	6 chunks	+4 lines, -104 lines	0 comments	Download
M	include/utils/SkUnitMappers.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/Sk64.cpp	View	2 chunks	+2 lines, -52 lines	0 comments	Download
D	src/core/SkCordic.h	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	src/core/SkCordic.cpp	View	1 chunk	+0 lines, -289 lines	0 comments	Download
M	src/core/SkFloat.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkMath.cpp	View	6 chunks	+1 line, -214 lines	0 comments	Download
M	src/core/SkMathPriv.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/effects/gradients/SkLinearGradient.cpp	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/utils/SkUnitMappers.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/MathTest.cpp	View	4 chunks	+0 lines, -76 lines	0 comments	Download
M	tests/Sk64Test.cpp	View	1 chunk	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

caryclark

lgtm https://codereview.chromium.org/113873008/diff/1/experimental/Intersection/SkAntiEdge.cpp File experimental/Intersection/SkAntiEdge.cpp (right): https://codereview.chromium.org/113873008/diff/1/experimental/Intersection/SkAntiEdge.cpp#newcode16 experimental/Intersection/SkAntiEdge.cpp:16: } alternatives -- - let experimental/Intersection bit rot ...

7 years ago (2013-12-19 13:56:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r12767 (presubmit successful).

Expand Messages | Collapse Messages