Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 113873005: Make bench_pictures' timing more GPU friendly (Closed)

Created:
7 years ago by robertphillips
Modified:
7 years ago
Reviewers:
borenet, bsalomon, benchen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This updates bench_pictures' timing methodology to more correctly reflect the GPU use case. Ben & Eric - will this work with the performance infrastructure? It replaces the old output: running bench [1257 3194] tabl_worldjournal.skp simple_viewport_1500x1000_gpu: msecs = 22.22 cmsecs = 22.62 with: running bench [1257 3194] tabl_worldjournal.skp simple_viewport_1500x1000_gpu <averaged>: msecs = 25.72 cmsecs = 24.18 Alternatively, we could just output the new timings without the "<averaged>" suffix.

Patch Set 1 #

Patch Set 2 : Make new output format match old #

Patch Set 3 : Make new output format match old #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
tools/PictureBenchmark.cpp View 1 1 chunk +32 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
7 years ago (2013-12-16 20:16:30 UTC) #1
benchen
Thanks Rob. If possible, please make the new outputs identical in format to the old ...
7 years ago (2013-12-16 20:25:41 UTC) #2
robertphillips
Fixed in latest patch.
7 years ago (2013-12-16 20:31:46 UTC) #3
benchen
On 2013/12/16 20:31:46, robertphillips wrote: > Fixed in latest patch. LGTM Brian, Joe is working ...
7 years ago (2013-12-16 20:47:29 UTC) #4
robertphillips
7 years ago (2013-12-17 13:40:38 UTC) #5
Message was sent while issue was closed.
committed as r12705

Powered by Google App Engine
This is Rietveld 408576698