Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: src/api.cc

Issue 1138723003: Fix has_pending_exception logic in API's Array::CloneElementAt (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index ea29d55709ca96df8c6f1cce99b9ad9bf19846e3..b9790eeb07252acb43488b15793d9efc56a4c68e 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6072,8 +6072,9 @@ MaybeLocal<Object> Array::CloneElementAt(Local<Context> context,
if (!paragon->IsJSObject()) return Local<Object>();
i::Handle<i::JSObject> paragon_handle(i::JSObject::cast(paragon));
Local<Object> result;
- has_pending_exception = ToLocal<Object>(
- isolate->factory()->CopyJSObject(paragon_handle), &result);
+ has_pending_exception =
+ !ToLocal<Object>(isolate->factory()->CopyJSObject(paragon_handle),
+ &result);
RETURN_ON_FAILED_EXECUTION(Object);
RETURN_ESCAPED(result);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698