Issue 1138723003: Fix has_pending_exception logic in API's Array::CloneElementAt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1138723003: Fix has_pending_exception logic in API's Array::CloneElementAt (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow

Modified:
5 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix has_pending_exception logic in API's Array::CloneElementAt BUG=v8:4103 LOG=y R=svenpanne@chromium.org Committed: https://crrev.com/c0144c0c64e67d78907d1da2aedeed78288ca374 Cr-Commit-Position: refs/heads/master@{#28477}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/api.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

Jakob Kummerow

As discussed. Do you think this needs a regression cctest, or shall we just fix ...

5 years, 7 months ago (2015-05-19 10:53:14 UTC) #1

Sven Panne

LGTM. IMHO a regression test is not really necessary, it was just a dumb typo ...

5 years, 7 months ago (2015-05-19 10:57:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138723003/1

5 years, 7 months ago (2015-05-19 11:10:46 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 11:35:29 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c0144c0c64e67d78907d1da2aedeed78288ca374
Cr-Commit-Position: refs/heads/master@{#28477}