Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1138653004: content: Port content_shell_crash_service target to GN build. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Port content_shell_crash_service target to GN build. This is necessary because it is one of the dependencies of the 'blink_tests' group that should be built. BUG=483171 R=avi@chromium.org,dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/795e01a8bedd2d680739a9e098393abef27110e5 Cr-Commit-Position: refs/heads/master@{#330164}

Patch Set 1 #

Total comments: 2

Patch Set 2 : windowed #

Patch Set 3 : crash_service #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
tfarina
5 years, 7 months ago (2015-05-13 23:39:16 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1138653004/diff/1/content/shell/BUILD.gn File content/shell/BUILD.gn (right): https://codereview.chromium.org/1138653004/diff/1/content/shell/BUILD.gn#newcode575 content/shell/BUILD.gn:575: #}, You get the equivalent of these msvs_settings by ...
5 years, 7 months ago (2015-05-13 23:42:44 UTC) #3
tfarina
https://codereview.chromium.org/1138653004/diff/1/content/shell/BUILD.gn File content/shell/BUILD.gn (right): https://codereview.chromium.org/1138653004/diff/1/content/shell/BUILD.gn#newcode575 content/shell/BUILD.gn:575: #}, On 2015/05/13 23:42:44, Dirk Pranke wrote: > You ...
5 years, 7 months ago (2015-05-14 00:23:08 UTC) #4
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-14 00:28:29 UTC) #5
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-14 00:37:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138653004/20001
5 years, 7 months ago (2015-05-15 17:29:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_dbg on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_dbg/builds/486)
5 years, 7 months ago (2015-05-15 17:39:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138653004/40001
5 years, 7 months ago (2015-05-15 18:15:02 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-15 19:30:06 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 19:30:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/795e01a8bedd2d680739a9e098393abef27110e5
Cr-Commit-Position: refs/heads/master@{#330164}

Powered by Google App Engine
This is Rietveld 408576698