Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1138643012: ui/gfx: Add exclusion for testing/gmock to DEPS. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, Ben Goodger (Google)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/gfx: Add exclusion for testing/gmock to DEPS. This is so we can prevent other from adding this dependency back. They will think twice or at least consult with OWNERS if we have this in place in the DEPS exclusion list. BUG=134675 TEST=checkdeps R=sky@chromium.org Committed: https://crrev.com/76ebffc02eb4275a837ae8122bed5628ed44f513 Cr-Commit-Position: refs/heads/master@{#330392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/gfx/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 7 months ago (2015-05-16 01:25:50 UTC) #1
sky
LGTM
5 years, 7 months ago (2015-05-18 16:55:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138643012/1
5 years, 7 months ago (2015-05-18 17:03:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:17:10 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:41:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76ebffc02eb4275a837ae8122bed5628ed44f513
Cr-Commit-Position: refs/heads/master@{#330392}

Powered by Google App Engine
This is Rietveld 408576698