Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1138643007: IndexedDB: Zero no longer a valid value for maxCount in getAll(). (Closed)

Created:
5 years, 7 months ago by cmumford
Modified:
5 years, 7 months ago
Reviewers:
jsbell
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Zero no longer a valid value for maxCount in getAll(). Prior IDBObjectStore.getAll implementation used zero as the sentinel value for maxCount to mean unlimited. This change eliminates that check on the Chrome side. It is now the callers (Blink's) responsibility to pass in a very large number (MAXUINT) if the intent is to have the response be unbounded. BUG=457450 Committed: https://crrev.com/ca3da5230ce8725714fbeae15a9afbcb178f3ca3 Cr-Commit-Position: refs/heads/master@{#330225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/indexed_db/indexed_db_database.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cmumford
5 years, 7 months ago (2015-05-15 18:33:27 UTC) #2
jsbell
lgtm
5 years, 7 months ago (2015-05-15 21:15:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138643007/1
5 years, 7 months ago (2015-05-15 21:27:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 23:09:45 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:28:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca3da5230ce8725714fbeae15a9afbcb178f3ca3
Cr-Commit-Position: refs/heads/master@{#330225}

Powered by Google App Engine
This is Rietveld 408576698