Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 1138643006: Fix race in debug assertion. (Closed)

Created:
5 years, 7 months ago by koda
Modified:
5 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix race in debug assertion. Change order of initialization for the two-way pointers between Isolate and Thread. This only affects the debug assertion in Isolate::mutator_thread(). R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/thread.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 7 months ago (2015-05-15 15:44:36 UTC) #1
Ivan Posva
LGTM -ip
5 years, 7 months ago (2015-05-15 15:46:55 UTC) #2
koda
5 years, 7 months ago (2015-05-15 16:28:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698