Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1138643005: Clean-up aligned allocation logic. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean-up aligned allocation logic. BUG= Committed: https://crrev.com/055d4ee19cf12d0ec590b0d9e992a610cc62cd6c Cr-Commit-Position: refs/heads/master@{#28430}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -90 lines) Patch
M src/heap/heap.cc View 1 3 chunks +10 lines, -24 lines 0 comments Download
M src/heap/heap-inl.h View 3 chunks +4 lines, -20 lines 0 comments Download
M src/heap/mark-compact.cc View 1 4 chunks +13 lines, -31 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +12 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/spaces-inl.h View 4 chunks +26 lines, -2 lines 0 comments Download
M test/cctest/cctest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-spaces.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-15 15:12:33 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1138643005/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1138643005/diff/1/src/heap/heap.cc#newcode2178 src/heap/heap.cc:2178: heap->old_space()->AllocateRaw(object_size, kDoubleAligned); same here? https://codereview.chromium.org/1138643005/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1138643005/diff/1/src/heap/mark-compact.cc#newcode1955 ...
5 years, 7 months ago (2015-05-15 15:21:11 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1138643005/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1138643005/diff/1/src/heap/heap.cc#newcode2178 src/heap/heap.cc:2178: heap->old_space()->AllocateRaw(object_size, kDoubleAligned); On 2015/05/15 15:21:11, jochen (traveling) wrote: > ...
5 years, 7 months ago (2015-05-15 15:41:01 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-15 15:43:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138643005/20001
5 years, 7 months ago (2015-05-15 15:44:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 17:04:54 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 17:05:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/055d4ee19cf12d0ec590b0d9e992a610cc62cd6c
Cr-Commit-Position: refs/heads/master@{#28430}

Powered by Google App Engine
This is Rietveld 408576698