Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1138643003: Make sure that idle scavenges are just performed when enough objects are allocated in new space. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sure that idle scavenges are just performed when enough objects are allocated in new space. BUG= Committed: https://crrev.com/6ead193b51105d1ed5796a7ba417bb62d0323176 Cr-Commit-Position: refs/heads/master@{#28428}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 3 chunks +13 lines, -6 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-15 12:17:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138643003/1
5 years, 7 months ago (2015-05-15 12:50:50 UTC) #6
Erik Corry
https://codereview.chromium.org/1138643003/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1138643003/diff/1/src/heap/gc-idle-time-handler.cc#newcode141 src/heap/gc-idle-time-handler.cc:141: // The allocated new space limit to trigger a ...
5 years, 7 months ago (2015-05-15 13:03:16 UTC) #9
Erik Corry
lgtm
5 years, 7 months ago (2015-05-15 13:03:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138643003/20001
5 years, 7 months ago (2015-05-15 15:12:05 UTC) #13
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-15 15:12:07 UTC) #15
Hannes Payer (out of office)
https://codereview.chromium.org/1138643003/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1138643003/diff/1/src/heap/gc-idle-time-handler.cc#newcode141 src/heap/gc-idle-time-handler.cc:141: // The allocated new space limit to trigger a ...
5 years, 7 months ago (2015-05-15 15:12:49 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138643003/20001
5 years, 7 months ago (2015-05-15 15:22:51 UTC) #18
Erik Corry Chromium.org
lgtm
5 years, 7 months ago (2015-05-15 15:23:11 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 16:02:26 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138643003/20001
5 years, 7 months ago (2015-05-15 16:04:15 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 16:06:28 UTC) #24
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:06:37 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ead193b51105d1ed5796a7ba417bb62d0323176
Cr-Commit-Position: refs/heads/master@{#28428}

Powered by Google App Engine
This is Rietveld 408576698