Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1138613002: Handle exception writing to Chromoting host's stdin. (Closed)

Created:
5 years, 7 months ago by Lambros
Modified:
5 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle exception writing to Chromoting host's stdin. The linux_me2me_host script launches the host process, then writes the JSON config to the child's stdin. If the host process dies before the data is written to stdin, an IOError (EPIPE) exception is raised. This CL handles the exception and retries launching the host, instead of exiting the script. To test this, I added a time.sleep(5) call between launching the host and writing the config to stdin. This allowed me enough time to simulate the error by killing the host process. BUG=473441 Committed: https://crrev.com/acfbcb214d2af95cdc8e0e16b809db8fde878494 Cr-Commit-Position: refs/heads/master@{#329273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M remoting/host/linux/linux_me2me_host.py View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lambros
5 years, 7 months ago (2015-05-09 01:05:14 UTC) #2
Sergey Ulanov
lgtm
5 years, 7 months ago (2015-05-09 01:29:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138613002/1
5 years, 7 months ago (2015-05-09 01:42:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 05:50:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138613002/1
5 years, 7 months ago (2015-05-11 23:06:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 23:43:47 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 23:45:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acfbcb214d2af95cdc8e0e16b809db8fde878494
Cr-Commit-Position: refs/heads/master@{#329273}

Powered by Google App Engine
This is Rietveld 408576698