Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138603005: [Smart Lock] Update password generation confirmation to use new branding (Closed)

Created:
5 years, 7 months ago by Garrett Casto
Modified:
5 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, estade+watch_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Update password generation confirmation to use new branding BUG=486739 Committed: https://crrev.com/edafbf4613c91c45d49ceb35db3fd23205bf8fc0 Cr-Commit-Position: refs/heads/master@{#330198}

Patch Set 1 : New base #

Patch Set 2 : Cleanup #

Patch Set 3 : Remove android #

Patch Set 4 : Rebase #

Patch Set 5 : Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 1 2 3 4 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 2 3 4 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Garrett Casto
5 years, 7 months ago (2015-05-15 07:05:07 UTC) #3
vabr (Chromium)
lgtm
5 years, 7 months ago (2015-05-15 11:42:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138603005/80001
5 years, 7 months ago (2015-05-15 19:11:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/17037) linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-15 19:43:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138603005/100001
5 years, 7 months ago (2015-05-15 19:54:53 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 7 months ago (2015-05-15 21:12:13 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:27:36 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/edafbf4613c91c45d49ceb35db3fd23205bf8fc0
Cr-Commit-Position: refs/heads/master@{#330198}

Powered by Google App Engine
This is Rietveld 408576698