Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1138603003: [strong] Fix super in strong classes (Closed)

Created:
5 years, 7 months ago by arv (Not doing code reviews)
Modified:
5 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev, Erik Corry Chromium.org
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Fix super in strong classes The functions of strong classes are born non extensible. But, when the class is created we need to add an own private symbol representing the [[HomeObject]] slot in the spec. Like for the hidden_string property, we allow adding private own symbols to non extensible objects. BUG=v8:4077 LOG=N R=rossberg@chromium.org Committed: https://crrev.com/55a7500343f5fe03b6da12ee5c7ef9761da8c269 Cr-Commit-Position: refs/heads/master@{#28447}

Patch Set 1 #

Patch Set 2 : Enable super spread call tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -139 lines) Patch
M src/isolate.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/mjsunit/strong/function-arity.js View 1 8 chunks +93 lines, -139 lines 0 comments Download
A test/mjsunit/strong/super.js View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
arv (Not doing code reviews)
PTAL Erik, FYI, your change to Isolate::IsInternallyUsedPropertyName works perfectly.
5 years, 7 months ago (2015-05-14 20:48:49 UTC) #1
arv (Not doing code reviews)
Enable super spread call tests
5 years, 7 months ago (2015-05-14 23:39:18 UTC) #2
arv (Not doing code reviews)
Enable super spread call tests
5 years, 7 months ago (2015-05-14 23:40:51 UTC) #3
arv (Not doing code reviews)
Ping
5 years, 7 months ago (2015-05-15 14:29:35 UTC) #5
rossberg
lgtm
5 years, 7 months ago (2015-05-18 13:45:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138603003/40001
5 years, 7 months ago (2015-05-18 13:56:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-18 14:18:56 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 14:19:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55a7500343f5fe03b6da12ee5c7ef9761da8c269
Cr-Commit-Position: refs/heads/master@{#28447}

Powered by Google App Engine
This is Rietveld 408576698