Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2181)

Unified Diff: gpu/command_buffer/service/gpu_tracer.cc

Issue 1138603002: Fix some issues with the GPU Tracer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed glFlush(), land later and monitor metrics Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/gpu_tracer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gpu_tracer.cc
diff --git a/gpu/command_buffer/service/gpu_tracer.cc b/gpu/command_buffer/service/gpu_tracer.cc
index 3d8cce70507c1ca36f5ee92aef15ae364cbf9c50..e6c1e7fc8acb45da899d2e1aa9e1d655e321b2d3 100644
--- a/gpu/command_buffer/service/gpu_tracer.cc
+++ b/gpu/command_buffer/service/gpu_tracer.cc
@@ -66,7 +66,7 @@ void TraceOutputter::TraceDevice(GpuTracerSource source,
TRACE_EVENT_COPY_BEGIN_WITH_ID_TID_AND_TIMESTAMP2(
TRACE_DISABLED_BY_DEFAULT("gpu.device"),
name.c_str(),
- static_cast<int>(source),
+ local_trace_device_id_,
named_thread_.thread_id(),
start_time,
"gl_category",
@@ -76,13 +76,14 @@ void TraceOutputter::TraceDevice(GpuTracerSource source,
TRACE_EVENT_COPY_END_WITH_ID_TID_AND_TIMESTAMP2(
TRACE_DISABLED_BY_DEFAULT("gpu.device"),
name.c_str(),
- static_cast<int>(source),
+ local_trace_device_id_,
named_thread_.thread_id(),
end_time,
"gl_category",
category.c_str(),
"channel",
kGpuTraceSourceNames[source]);
+ ++local_trace_device_id_;
}
void TraceOutputter::TraceServiceBegin(GpuTracerSource source,
@@ -91,18 +92,25 @@ void TraceOutputter::TraceServiceBegin(GpuTracerSource source,
DCHECK(source >= 0 && source < NUM_TRACER_SOURCES);
TRACE_EVENT_COPY_NESTABLE_ASYNC_BEGIN_WITH_TTS2(
TRACE_DISABLED_BY_DEFAULT("gpu.service"),
- name.c_str(), static_cast<int>(source),
+ name.c_str(), local_trace_service_id_,
"gl_category", category.c_str(),
"channel", kGpuTraceSourceNames[source]);
+
+ trace_service_id_stack_[source].push(local_trace_service_id_);
+ ++local_trace_service_id_;
}
void TraceOutputter::TraceServiceEnd(GpuTracerSource source,
const std::string& category,
const std::string& name) {
DCHECK(source >= 0 && source < NUM_TRACER_SOURCES);
+ DCHECK(!trace_service_id_stack_[source].empty());
+ const uint64 local_trace_id = trace_service_id_stack_[source].top();
+ trace_service_id_stack_[source].pop();
+
TRACE_EVENT_COPY_NESTABLE_ASYNC_END_WITH_TTS2(
TRACE_DISABLED_BY_DEFAULT("gpu.service"),
- name.c_str(), static_cast<int>(source),
+ name.c_str(), local_trace_id,
"gl_category", category.c_str(),
"channel", kGpuTraceSourceNames[source]);
}
« no previous file with comments | « gpu/command_buffer/service/gpu_tracer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698