Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 1138603002: Fix some issues with the GPU Tracer. (Closed)

Created:
5 years, 7 months ago by David Yen
Modified:
5 years, 7 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some issues with the GPU Tracer. I had thought the trace ID for async markers were no longer relevant since I was using the trace source channel as the ID, but sometimes they overlap because of timing variances and mess up the traces. I've made each marker have it's own unique ID once again. R=vmiura@chromium.org BUG=478923 Committed: https://crrev.com/151b6d69a92ec2abbe34a6992093a2ca4e597b3e Cr-Commit-Position: refs/heads/master@{#329155}

Patch Set 1 #

Patch Set 2 : Removed glFlush(), land later and monitor metrics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M gpu/command_buffer/service/gpu_tracer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
David Yen
5 years, 7 months ago (2015-05-08 23:56:07 UTC) #1
David Yen
+piman to review ui/gl/gpu_timing.cc
5 years, 7 months ago (2015-05-08 23:57:00 UTC) #3
David Yen
On 2015/05/08 23:57:00, David Yen wrote: > +piman to review ui/gl/gpu_timing.cc -piman, decided to add ...
5 years, 7 months ago (2015-05-09 00:01:19 UTC) #5
vmiura
lgtm
5 years, 7 months ago (2015-05-09 00:05:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138603002/20001
5 years, 7 months ago (2015-05-09 00:16:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 04:17:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138603002/20001
5 years, 7 months ago (2015-05-11 15:22:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 16:30:37 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 16:32:02 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/151b6d69a92ec2abbe34a6992093a2ca4e597b3e
Cr-Commit-Position: refs/heads/master@{#329155}

Powered by Google App Engine
This is Rietveld 408576698