content/renderer/history_controller.cc - Issue 1138543002: Better remove HistoryNodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/history_controller.cc

Issue 1138543002: Better remove HistoryNodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/history_controller.cc

diff --git a/content/renderer/history_controller.cc b/content/renderer/history_controller.cc

index f2d3d96d341213eeb0ceda09b3d1aa2d1c9fd9e3..850bae3cd07bb50effed94210195cfce8469028d 100644

--- a/content/renderer/history_controller.cc

+++ b/content/renderer/history_controller.cc

@@ -179,6 +179,8 @@ void HistoryController::UpdateForCommit(RenderFrameImpl* frame,

if (current_entry_) {

if (HistoryEntry::HistoryNode* node =

current_entry_->GetHistoryNodeForFrame(frame)) {

+ if (!navigation_within_page)

+ node->RemoveChildren();

node->set_item(item);

}

« no previous file with comments | « no previous file | content/renderer/history_entry.h » ('j') | content/renderer/history_entry.h » ('J')