Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/renderer/history_controller.cc

Issue 1138543002: Better remove HistoryNodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove frame sequence numbers from serialization Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/page_state_serialization_unittest.cc ('k') | content/renderer/history_entry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/history_controller.cc
diff --git a/content/renderer/history_controller.cc b/content/renderer/history_controller.cc
index f2d3d96d341213eeb0ceda09b3d1aa2d1c9fd9e3..5f53009158b24e4d5a4e14ca3b8a41525c8cae7d 100644
--- a/content/renderer/history_controller.cc
+++ b/content/renderer/history_controller.cc
@@ -153,7 +153,7 @@ void HistoryController::UpdateForInitialLoadInChildFrame(
return;
if (HistoryEntry::HistoryNode* parent_history_node =
current_entry_->GetHistoryNodeForFrame(parent)) {
- parent_history_node->AddChild(item, frame->GetRoutingID());
+ parent_history_node->AddChild(item);
}
}
@@ -217,8 +217,7 @@ void HistoryController::CreateNewBackForwardItem(
const WebHistoryItem& new_item,
bool clone_children_of_target) {
if (!current_entry_) {
- current_entry_.reset(
- new HistoryEntry(new_item, target_frame->GetRoutingID()));
+ current_entry_.reset(new HistoryEntry(new_item));
} else {
current_entry_.reset(current_entry_->CloneAndReplace(
new_item, clone_children_of_target, target_frame, render_view_));
« no previous file with comments | « content/common/page_state_serialization_unittest.cc ('k') | content/renderer/history_entry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698