Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: content/renderer/history_controller.cc

Issue 1138543002: Better remove HistoryNodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/history_entry.h » ('j') | content/renderer/history_entry.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/history_controller.cc
diff --git a/content/renderer/history_controller.cc b/content/renderer/history_controller.cc
index 850bae3cd07bb50effed94210195cfce8469028d..73ae592d4157d316cf18fadb477371326ee76458 100644
--- a/content/renderer/history_controller.cc
+++ b/content/renderer/history_controller.cc
@@ -153,7 +153,7 @@ void HistoryController::UpdateForInitialLoadInChildFrame(
return;
if (HistoryEntry::HistoryNode* parent_history_node =
current_entry_->GetHistoryNodeForFrame(parent)) {
- parent_history_node->AddChild(item, frame->GetRoutingID());
+ parent_history_node->AddChild(item);
}
}
@@ -219,8 +219,7 @@ void HistoryController::CreateNewBackForwardItem(
const WebHistoryItem& new_item,
bool clone_children_of_target) {
if (!current_entry_) {
- current_entry_.reset(
- new HistoryEntry(new_item, target_frame->GetRoutingID()));
+ current_entry_.reset(new HistoryEntry(new_item));
} else {
current_entry_.reset(current_entry_->CloneAndReplace(
new_item, clone_children_of_target, target_frame, render_view_));
« no previous file with comments | « no previous file | content/renderer/history_entry.h » ('j') | content/renderer/history_entry.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698