Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/runtime/dart_runtime.js

Issue 1138533003: fixes #175, fixed arrays (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/browser/runtime_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_runtime.js
diff --git a/lib/runtime/dart_runtime.js b/lib/runtime/dart_runtime.js
index 4dd786854bbc73cbf361ae368de82cd4a0757c5c..8ba16b429885a51ec571a4213f65ddad68886f4c 100644
--- a/lib/runtime/dart_runtime.js
+++ b/lib/runtime/dart_runtime.js
@@ -967,7 +967,8 @@ var dart, _js_helper, _js_primitives;
dart.JsSymbol = Symbol;
function import_(value) {
- if (!value) throw 'missing required module';
+ // TODO(jmesserly): enable this once we're loading all of core libs.
+ // if (!value) throw 'missing required module';
vsm 2015/05/08 21:27:21 Log a warning instead?
Jennifer Messerly 2015/05/08 21:33:25 sure thing.
return value;
}
dart.import = import_;
« no previous file with comments | « no previous file | test/browser/runtime_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698