Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138533003: fixes #175, fixed arrays (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : warn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M lib/runtime/dart_runtime.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M test/browser/runtime_tests.js View 1 chunk +10 lines, -0 lines 0 comments Download
M test/generated_sdk/lib/_internal/compiler/js_lib/js_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/private/js_array.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 7 months ago (2015-05-08 21:11:51 UTC) #2
vsm
lgtm https://codereview.chromium.org/1138533003/diff/1/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1138533003/diff/1/lib/runtime/dart_runtime.js#newcode971 lib/runtime/dart_runtime.js:971: // if (!value) throw 'missing required module'; Log ...
5 years, 7 months ago (2015-05-08 21:27:22 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1138533003/diff/1/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1138533003/diff/1/lib/runtime/dart_runtime.js#newcode971 lib/runtime/dart_runtime.js:971: // if (!value) throw 'missing required module'; On 2015/05/08 ...
5 years, 7 months ago (2015-05-08 21:33:25 UTC) #4
Jennifer Messerly
5 years, 7 months ago (2015-05-08 21:33:43 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
99e1bc60d0f2d4293cd74b3ee24ebdb17429fe65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698