Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: ui/views/controls/menu/menu_event_filter.h

Issue 1138523006: Enable keyboard accelerators while a menu is open (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't stop the event's propagation when the menu has exited. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/menu/menu_event_filter.h
diff --git a/ui/views/controls/menu/menu_event_filter.h b/ui/views/controls/menu/menu_event_filter.h
new file mode 100644
index 0000000000000000000000000000000000000000..cb976e47a88216ba28e5661b51a46915b7063484
--- /dev/null
+++ b/ui/views/controls/menu/menu_event_filter.h
@@ -0,0 +1,85 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_VIEWS_CONTROLS_MENU_MENU_EVENT_FILTER_H_
+#define UI_VIEWS_CONTROLS_MENU_MENU_EVENT_FILTER_H_
+
+#include "base/logging.h"
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "ui/events/event_handler.h"
+#include "ui/views/views_export.h"
+
+namespace aura {
+class Window;
+} // namespace aura
+
+namespace ui {
+class Accelerator;
+} // namespace ui
+
+namespace views {
+
+class MenuController;
+
+// This will be used as a pre-target-handler whenever a menu is present. It is
+// needed to handle the interactions between accelerators and menus.
+class VIEWS_EXPORT MenuEventFilter : public ui::EventHandler {
+ public:
+ // Defines a delegate interface for the MenuEventFilter that can handle
+ // accelerators on its behalf.
+ class Delegate {
+ public:
+ enum Result {
+ RESULT_PROCESSED = 0, // Accelerator was processed while menu is open.
+ RESULT_PROCESS_LATER, // Accelerator should be processed after menu
+ // closes.
+ };
+
+ Delegate() {}
+ virtual ~Delegate() {}
+
+ // When a KeyEvent is received, the corresponding |accelerator| must be
+ // stored in the |AcceleratorHistory| so that accelerator processing can
+ // be done properly.
+ virtual void StoreInHistory(const ui::Accelerator& accelerator) = 0;
+
+ // Returns false if the |accelerator| can be performed while the menu is
+ // open, or true if the menu should be closed an the accelerator should be
+ // reposted after the menu exists to be performed later.
+ virtual bool ShouldCloseMenuAndRepostAccelerator(
+ const ui::Accelerator& accelerator) const = 0;
+
+ // Processes the given |accelerator| immediately regardless of the action
+ // associated with it.
+ virtual void ProcessAcceleratorNow(const ui::Accelerator& accelerator) = 0;
+ };
+
+ MenuEventFilter(MenuController* menu_controller);
+ ~MenuEventFilter() override;
+
+ static void SetMenuEventFilterDelegate(aura::Window* root_window,
+ MenuEventFilter::Delegate* delegate);
+ static MenuEventFilter::Delegate* GetMenuEventFilterDelegate(
+ aura::Window* root_window);
+
+ // ui::EventHandler:
+ void OnKeyEvent(ui::KeyEvent* event) override;
+ void OnTouchEvent(ui::TouchEvent* event) override;
+
+ void SetDelegate(MenuEventFilter::Delegate* delegate);
+ void ClearDelegate();
+
+ private:
+ MenuController* menu_controller_;
+ scoped_ptr<MenuEventFilter::Delegate> default_delegate_;
+ MenuEventFilter::Delegate* filter_delegate_; // Not owned.
+
+ DISALLOW_COPY_AND_ASSIGN(MenuEventFilter);
+};
+
+} // namespace views
+
+
+#endif // UI_VIEWS_CONTROLS_MENU_MENU_EVENT_FILTER_H_

Powered by Google App Engine
This is Rietveld 408576698