Enable keyboard accelerators while a menu is open

ash/accelerators/accelerator_table.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_table.h"
 
 #include "ash/strings/grit/ash_strings.h"
 #include "base/basictypes.h"
 
 namespace ash {
@@ skipping 454 matching lines @@
     WINDOW_CYCLE_SNAP_DOCK_RIGHT,
     WINDOW_MINIMIZE,
     TOGGLE_FULLSCREEN,
     TOGGLE_MAXIMIZED,
     WINDOW_POSITION_CENTER,
     ROTATE_WINDOW,
 };
 
 const size_t kActionsNeedingWindowLength = arraysize(kActionsNeedingWindow);
 
+const AcceleratorAction kActionsKeepingMenuOpen[] = {
+    MEDIA_NEXT_TRACK,
+    MEDIA_PLAY_PAUSE,
+    MEDIA_PREV_TRACK,
+    NEXT_IME,
+    PREVIOUS_IME,
+    PRINT_UI_HIERARCHIES,
+    SWITCH_IME,
+    TAKE_PARTIAL_SCREENSHOT,
+    TAKE_SCREENSHOT,
+#if defined(OS_CHROMEOS)
+    BRIGHTNESS_DOWN,
+    BRIGHTNESS_UP,
+    DISABLE_CAPS_LOCK,
+    KEYBOARD_BRIGHTNESS_DOWN,
+    KEYBOARD_BRIGHTNESS_UP,
+    SILENCE_SPOKEN_FEEDBACK,
+    TOGGLE_CAPS_LOCK,
+    TOGGLE_SPOKEN_FEEDBACK,
+    TOGGLE_WIFI,

[pkotwicz, 2015/09/10 21:58:49]

TOGGLE_WIFI is a weird accelerator to include in the list too. All of the other
accelerators look reasonable. (I would vote to remove MEDIA_NEXT_TRACK,
MEDIA_PLAY_PAUSE and MEDIA_PREV_TRACK from this list too but I can see why
someone may want to include it)

[afakhry, 2015/09/10 23:31:02]

Remember that this list contains actions that will be performed while the menu
is kept open. I don't see a reason to exclude TOGGLE_WIFI. Why should the
accelerator for toggling the wifi close the menu and be performed after that?

[pkotwicz, 2015/09/10 23:37:33]

The way I think of it is that this list should be kept as small as possible. We
need to make sure that none of these actions have bad interactions with the menu
being open. (I doubt that TOGGLE_WIFI has a bad interaction with the menu being
open) When I look at the list, I ask myself for each accelerator: "Why should
the menu stay open when the accelerator is pressed?"

+    VOLUME_DOWN,
+    VOLUME_MUTE,
+    VOLUME_UP,
+#endif  // defined(OS_CHROMEOS)
+};
+
+const size_t kActionsKeepingMenuOpenLength = arraysize(kActionsKeepingMenuOpen);
+
 }  // namespace ash