Enable keyboard accelerators while a menu is open

ui/views/views_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_VIEWS_DELEGATE_H_
 #define UI_VIEWS_VIEWS_DELEGATE_H_
 
 #include <string>
 
 #if defined(OS_WIN)
@@ skipping 55 matching lines @@
  public:
 #if defined(OS_WIN)
   enum AppbarAutohideEdge {
     EDGE_TOP    = 1 << 0,
     EDGE_LEFT   = 1 << 1,
     EDGE_BOTTOM = 1 << 2,
     EDGE_RIGHT  = 1 << 3,
   };
 #endif
 
+  enum ProcessMenuAcceleratorResult {

[sky, 2015/09/10 16:20:33]

enum class

[afakhry, 2015/09/10 17:00:29]

Done.

+    // The accelerator was handled while the menu was showing. No further action
+    // is needed.
+    ACCELERATOR_HANDLED,

[sky, 2015/09/10 16:20:33]

The names and use is counter what I would have expected. How about renaming to
CLOSE_MENU and LEAVE_MENU_OPEN to better clarify what happens.

[afakhry, 2015/09/10 17:00:29]

Done.

+
+    // The accelerator was not handled. Menu should be closed and the
+    // accelerator will be reposted to be handled after the menu closes.
+    ACCELERATOR_NOT_HANDLED
+  };
+
   virtual ~ViewsDelegate();
 
   // Returns the ViewsDelegate instance if there is one, or nullptr otherwise.
   static ViewsDelegate* GetInstance();
 
   // Saves the position, size and "show" state for the window with the
   // specified name.
   virtual void SaveWindowPlacement(const Widget* widget,
                                    const std::string& window_name,
                                    const gfx::Rect& bounds,
                                    ui::WindowShowState show_state);
 
   // Retrieves the saved position and size and "show" state for the window with
   // the specified name.
   virtual bool GetSavedWindowPlacement(const Widget* widget,
                                        const std::string& window_name,
                                        gfx::Rect* bounds,
                                        ui::WindowShowState* show_state) const;
 
   virtual void NotifyAccessibilityEvent(View* view, ui::AXEvent event_type);
 
   // For accessibility, notify the delegate that a menu item was focused
   // so that alternate feedback (speech / magnified text) can be provided.
   virtual void NotifyMenuItemFocused(const base::string16& menu_name,
                                      const base::string16& menu_item_name,
                                      int item_index,
                                      int item_count,
                                      bool has_submenu);
 
+  virtual ProcessMenuAcceleratorResult ProcessAcceleratorWhileMenuShowing(
+      const ui::Accelerator& accelerator);
+
 #if defined(OS_WIN)
   // Retrieves the default window icon to use for windows if none is specified.
   virtual HICON GetDefaultWindowIcon() const;
   // Retrieves the small window icon to use for windows if none is specified.
   virtual HICON GetSmallWindowIcon() const = 0;
   // Returns true if the window passed in is in the Windows 8 metro
   // environment.
   virtual bool IsWindowInMetro(gfx::NativeWindow window) const;
 #elif defined(OS_LINUX) && !defined(OS_CHROMEOS)
   virtual gfx::ImageSkia* GetDefaultWindowIcon() const;
@@ skipping 56 matching lines @@
 #if defined(USE_AURA)
   scoped_ptr<TouchSelectionMenuRunnerViews> touch_selection_menu_runner_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(ViewsDelegate);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_VIEWS_DELEGATE_H_