Enable keyboard accelerators while a menu is open

ui/views/controls/menu/menu_event_handler.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_VIEWS_CONTROLS_MENU_MENU_EVENT_HANDLER_H_
+#define UI_VIEWS_CONTROLS_MENU_MENU_EVENT_HANDLER_H_
+
+#include "base/macros.h"
+#include "ui/events/event_handler.h"
+#include "ui/views/views_export.h"
+
+namespace ui {
+class Accelerator;
+}
+
+namespace views {
+
+// Handles events while a menu is open.
+class VIEWS_EXPORT MenuEventHandler : public ui::EventHandler {

[sky, 2015/09/09 15:44:52]

MenuEventHandler, and your description, are too generic. This class is primarily
about handling key events. A better name is MenuKeyEventHandler.

[afakhry, 2015/09/09 20:21:33]

Even with the OnTouchEvent() present?

[sky, 2015/09/09 21:30:55]

While not 100% accurate I feel that MenuKeyEventHandler is more descriptive.
Particularly because menu already handles many events, so to name it
MenuEventHandler implies it handles all events.

[afakhry, 2015/09/09 23:59:52]

Done.

+ public:
+  MenuEventHandler();
+  ~MenuEventHandler() override;
+
+  // ui::EventHandler:
+  void OnKeyEvent(ui::KeyEvent* event) override;
+  void OnTouchEvent(ui::TouchEvent* event) override;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MenuEventHandler);
+};
+
+}  // namespace views
+
+#endif  // UI_VIEWS_CONTROLS_MENU_MENU_EVENT_HANDLER_H_